zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] ztzg commented on a change in pull request #934: ZOOKEEPER-3301:Enforce the quota limit
Date Wed, 08 Apr 2020 13:33:34 GMT
ztzg commented on a change in pull request #934: ZOOKEEPER-3301:Enforce the quota limit
URL: https://github.com/apache/zookeeper/pull/934#discussion_r405526980
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/DelQuotaCommand.java
 ##########
 @@ -43,11 +42,14 @@
     private CommandLine cl;
 
     public DelQuotaCommand() {
-        super("delquota", "[-n|-b] path");
+        super("delquota", "[-n|-b|-N|-B] path");
 
         OptionGroup og1 = new OptionGroup();
-        og1.addOption(new Option("b", false, "bytes quota"));
-        og1.addOption(new Option("n", false, "num quota"));
+        og1.addOption(new Option("n", false, "num soft quota"));
+        og1.addOption(new Option("b", false, "bytes soft quota"));
+        og1.addOption(new Option("N", false, "num hard quota"));
+        og1.addOption(new Option("B", false, "bytes hard quota"));
 
 Review comment:
   Okay—I'll take care of those :)
   
   (Including experimenting with `Option` vs. `OptionGroup`, as you suggested.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message