From notifications-return-2073-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Oct 2 21:31:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7F617180679 for ; Wed, 2 Oct 2019 23:31:56 +0200 (CEST) Received: (qmail 32400 invoked by uid 500); 2 Oct 2019 21:31:55 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 32232 invoked by uid 99); 2 Oct 2019 21:31:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Oct 2019 21:31:55 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] eolivelli commented on a change in pull request #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. Message-ID: <157005191544.27079.251724918643479965.gitbox@gitbox.apache.org> Date: Wed, 02 Oct 2019 21:31:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit eolivelli commented on a change in pull request #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1105#discussion_r330779982 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxnFactory.java ########## @@ -54,6 +54,7 @@ */ static final ByteBuffer closeConn = ByteBuffer.allocate(0); + private static String loginUser = System.getProperty("user.name", ""); Review comment: final? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services