From notifications-return-2032-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Oct 1 00:42:34 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 57FBD180656 for ; Tue, 1 Oct 2019 02:42:34 +0200 (CEST) Received: (qmail 71263 invoked by uid 500); 1 Oct 2019 00:42:33 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 71252 invoked by uid 99); 1 Oct 2019 00:42:33 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Oct 2019 00:42:33 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] enixon commented on issue #1098: ZOOKEEPER-3560: Add response cache to serve get children (2) requests. Message-ID: <156989055358.649.7558659917576938875.gitbox@gitbox.apache.org> Date: Tue, 01 Oct 2019 00:42:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit enixon commented on issue #1098: ZOOKEEPER-3560: Add response cache to serve get children (2) requests. URL: https://github.com/apache/zookeeper/pull/1098#issuecomment-536808973 Nice extension! The code looks good to me. My only question is whether it's better to separate the properties handling the two types of cache (though I appreciate the simplicity of your approach) and my only request is you update the documentation for *maxResponseCacheSize* to note that it also runs a "get children" cache. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services