From notifications-return-2021-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Tue Oct  1 00:29:49 2019
Return-Path: <notifications-return-2021-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 06586180656
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  1 Oct 2019 02:29:48 +0200 (CEST)
Received: (qmail 53602 invoked by uid 500); 1 Oct 2019 00:29:48 -0000
Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:notifications@zookeeper.apache.org>
List-Id: <notifications.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list notifications@zookeeper.apache.org
Received: (qmail 53588 invoked by uid 99); 1 Oct 2019 00:29:48 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Oct 2019 00:29:48 +0000
From: GitBox <git@apache.org>
To: notifications@zookeeper.apache.org
Subject: [GitHub] [zookeeper] enixon commented on a change in pull request #1100:
 ZOOKEEPER-3509: Revisit log format
Message-ID: <156988978814.12068.7483825031251748111.gitbox@gitbox.apache.org>
Date: Tue, 01 Oct 2019 00:29:48 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format
URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329840013
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
 ##########
 @@ -76,20 +76,20 @@ public WatcherCleaner(IDeadWatcherListener listener, int watcherCleanThreshold,
         int suggestedMaxInProcessingThreshold = watcherCleanThreshold * watcherCleanThreadsNum;
         if (maxInProcessingDeadWatchers > 0 && maxInProcessingDeadWatchers < suggestedMaxInProcessingThreshold) {
             maxInProcessingDeadWatchers = suggestedMaxInProcessingThreshold;
-            LOG.info("The maxInProcessingDeadWatchers config is smaller "
-                     + "than the suggested one, change it to use {}",
-                     maxInProcessingDeadWatchers);
+            LOG.info(
+                "The maxInProcessingDeadWatchers config is smaller than the suggested one, change it to use {}",
+                maxInProcessingDeadWatchers);
         }
         this.maxInProcessingDeadWatchers = maxInProcessingDeadWatchers;
         this.deadWatchers = new HashSet<Integer>();
         this.cleaners = new WorkerService("DeadWatcherCleanner", watcherCleanThreadsNum, false);
 
-        LOG.info("watcherCleanThreshold={}, watcherCleanIntervalInSeconds={}"
 
 Review comment:
   exactly :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services