zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] iamgd67 commented on a change in pull request #1114: ZOOKEEPER-3572: correctly handle zooinspector resources
Date Sat, 12 Oct 2019 01:26:06 GMT
iamgd67 commented on a change in pull request #1114: ZOOKEEPER-3572: correctly handle zooinspector
resources
URL: https://github.com/apache/zookeeper/pull/1114#discussion_r334213934
 
 

 ##########
 File path: zookeeper-contrib/zookeeper-contrib-zooinspector/pom.xml
 ##########
 @@ -96,4 +96,15 @@
     </dependency>
   </dependencies>
 
+  <build>
+    <resources>
+      <resource>
+        <directory>${project.basedir}/src/main/resources</directory>
+        <includes>
 
 Review comment:
   after doing some tests, got conclution as follow
   if not set resource, will use parent resource config
   if add one resource element config, parent config will not show in "effective pom"
   so actually, the include is not necessary, but direcotry is required
   will do a new commit remove the include

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message