zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] symat commented on issue #1048: ZOOKEEPER-3188: Improve resilience to network
Date Wed, 09 Oct 2019 07:51:08 GMT
symat commented on issue #1048: ZOOKEEPER-3188: Improve resilience to network
URL: https://github.com/apache/zookeeper/pull/1048#issuecomment-539883072
 
 
   Thanks @anmolnar for the testing, it is a nice catch! 
   (I always stopped after the first step, disabling one of the interfaces, never tried to
re-enable them)
   
   > After that I swapped the interfaces (cable plugged in, wifi disabled) and nodes went
back to looking state and were not able to form a quorum again. Not even after a restart!
   
   It is strange that even restart didn't help. Did you verify that you get the same IP address
after plugging-back the cable / re-enable WIFI?
   
   I think the easiest to test these things is to use docker. There is also the benefit of
having three different IP addresses. And we can disable / enable whole virtual networks or
single virtual network interfaces.
   
   > We might be able to fix this by changing Leader's constructor to not fail (createServerSocket())
when some of the addresses are failing to bind. We should have at least a single working interface.
   
   I think you are right. I think I ~~can~~ will actually cover this situation with a unit
test. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message