zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] sujithsimon22 commented on a change in pull request #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server
Date Wed, 09 Oct 2019 05:34:05 GMT
sujithsimon22 commented on a change in pull request #1108: ZOOKEEPER-2238: Support limiting
the maximum number of connections/clients to a zookeeper server
URL: https://github.com/apache/zookeeper/pull/1108#discussion_r332834750
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxnFactory.java
 ##########
 @@ -40,6 +40,8 @@
 public abstract class ServerCnxnFactory {
 
     public static final String ZOOKEEPER_SERVER_CNXN_FACTORY = "zookeeper.serverCnxnFactory";
+    private static final String ZOOKEEPER_MAX_CONNECTION = "zookeeper.maxCnxns";
+    public static final int ZOOKEEPER_MAX_CONNECTION_DEFAULT = 0;
 
 Review comment:
   I was thinking "zookeeper.maxCnxns" would give a more wholesome meaning since we are looking
at the maximum number of connections that the server can accept. Do u think we can keep the
name as it is since it does not cause any confusion ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message