zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.
Date Wed, 02 Oct 2019 21:31:55 GMT
eolivelli commented on a change in pull request #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper
servers.
URL: https://github.com/apache/zookeeper/pull/1105#discussion_r330776350
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/Login.java
 ##########
 @@ -286,6 +286,13 @@ public Subject getSubject() {
         return subject;
     }
 
+    public String getUserName() {
+        if (principal == null || principal.isEmpty()) {
+            return System.getProperty("user.name", "<NA>");
 
 Review comment:
   You can sample the value as a static variable. You will save an access to the system properties
map

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message