zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.
Date Wed, 02 Oct 2019 21:31:55 GMT
eolivelli commented on a change in pull request #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper
servers.
URL: https://github.com/apache/zookeeper/pull/1105#discussion_r330770996
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java
 ##########
 @@ -20,18 +20,22 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Deque;
+import java.util.HashMap;
 import java.util.LinkedList;
 import java.util.List;
+import java.util.Map;
 
 import org.apache.zookeeper.AsyncCallback.StringCallback;
 import org.apache.zookeeper.AsyncCallback.VoidCallback;
 import org.apache.zookeeper.KeeperException.Code;
 import org.apache.zookeeper.common.PathUtils;
+import org.apache.zookeeper.data.ACL;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public class ZKUtil {
     private static final Logger LOG = LoggerFactory.getLogger(ZKUtil.class);
+    private static final Map<Integer, String> permCache = new HashMap<Integer, String>();
 
 Review comment:
   ConcurrentHashMap?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message