zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch
Date Wed, 02 Oct 2019 10:48:32 GMT
eolivelli commented on a change in pull request #136: [ZOOKEEPER-1416] Persistent Recursive
Watch
URL: https://github.com/apache/zookeeper/pull/136#discussion_r330484335
 
 

 ##########
 File path: src/java/main/org/apache/zookeeper/server/WatchManager.java
 ##########
 @@ -40,50 +40,110 @@
 class WatchManager {
     private static final Logger LOG = LoggerFactory.getLogger(WatchManager.class);
 
-    private final Map<String, Set<Watcher>> watchTable =
-        new HashMap<String, Set<Watcher>>();
+    enum Type {
+        STANDARD() {
 
 Review comment:
   nit: you can have two field in the enum without creating subclasses

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message