zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] enixon commented on issue #1098: ZOOKEEPER-3560: Add response cache to serve get children (2) requests.
Date Tue, 01 Oct 2019 00:42:33 GMT
enixon commented on issue #1098: ZOOKEEPER-3560: Add response cache to serve get children (2)
requests.
URL: https://github.com/apache/zookeeper/pull/1098#issuecomment-536808973
 
 
   Nice extension!
   
   The code looks good to me. My only question is whether it's better to separate the properties
handling the two types of cache (though I appreciate the simplicity of your approach) and
my only request is you update the documentation for *maxResponseCacheSize* to note that it
also runs a "get children" cache.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message