zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] TisonKun commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format
Date Tue, 01 Oct 2019 00:40:50 GMT
TisonKun commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format
URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329841923
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientTest.java
 ##########
 @@ -140,15 +140,15 @@ public void testACLs() throws Exception {
                 zk.create("/acltest", new byte[0], testACL, CreateMode.PERSISTENT);
                 fail("Should have received an invalid acl error");
             } catch (InvalidACLException e) {
-                LOG.info("Test successful, invalid acl received : " + e.getMessage());
+                LOG.debug("Test successful, invalid acl received : " + e);
             }
             try {
                 ArrayList<ACL> testACL = new ArrayList<ACL>();
                 testACL.add(new ACL(Perms.ALL | Perms.ADMIN, new Id()));
                 zk.create("/nullidtest", new byte[0], testACL, CreateMode.PERSISTENT);
                 fail("Should have received an invalid acl error");
             } catch (InvalidACLException e) {
-                LOG.info("Test successful, invalid acl received : " + e.getMessage());
+                LOG.debug("Test successful, invalid acl received : " + e);
 
 Review comment:
   Thanks for the catch! After a closer look it is an intended exception so that
   
   ```java
   LOG.info("Test successful, invalid acl received : {}", e.getMessage());
   ```
   
   reflect the intention. Updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message