From notifications-return-1923-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Sep 20 20:44:18 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 60D3F180608 for ; Fri, 20 Sep 2019 22:44:18 +0200 (CEST) Received: (qmail 19525 invoked by uid 500); 20 Sep 2019 20:44:17 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 19516 invoked by uid 99); 20 Sep 2019 20:44:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Sep 2019 20:44:17 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] hanm commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable Message-ID: <156901225758.26859.4375718485803683345.gitbox@gitbox.apache.org> Date: Fri, 20 Sep 2019 20:44:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hanm commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r326796321 ########## File path: zookeeper-jute/src/main/java/org/apache/jute/BinaryInputArchive.java ########## @@ -27,8 +27,23 @@ * */ public class BinaryInputArchive implements InputArchive { - static public final String UNREASONBLE_LENGTH= "Unreasonable length = "; + public static final String UNREASONBLE_LENGTH= "Unreasonable length = "; + public static final int maxBuffer = Integer.getInteger("jute.maxbuffer", 0xfffff); + private static final int extraMaxBuffer; + + static { + Integer configuredExtraMaxBuffer = + Integer.getInteger("zookeeper.jute.maxbuffer.extrasize", maxBuffer); Review comment: one suggestion: existing maxbuffer has a name of "jute.maxbuffer" (note, without zookeeper prefix), so it might be better that we name this extra size property as "jute.maxbuffer.extrasize" to be consistent with existing style. also, we need documentation on this new property. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services