From notifications-return-1914-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Sep 20 07:40:55 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D62D9180608 for ; Fri, 20 Sep 2019 09:40:54 +0200 (CEST) Received: (qmail 49761 invoked by uid 500); 20 Sep 2019 07:40:54 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 49752 invoked by uid 99); 20 Sep 2019 07:40:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Sep 2019 07:40:54 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable Message-ID: <156896525414.4945.1314023080248559779.gitbox@gitbox.apache.org> Date: Fri, 20 Sep 2019 07:40:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit arshadmohammad commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r326506377 ########## File path: zookeeper-jute/src/main/java/org/apache/jute/BinaryInputArchive.java ########## @@ -85,6 +85,18 @@ public String readString(String tag) throws IOException { } static public final int maxBuffer = Integer.getInteger("jute.maxbuffer", 0xfffff); + static public final int readExtraSize; + + static { + Integer configuredValue = + Integer.getInteger("zookeeper.jute.maxbuffer.extrasize", maxBuffer); + if (configuredValue < 1024) { + // Earlier hard coded value is 1024, So the value should not be less than that + readExtraSize = 1024; Review comment: In this patch we have changed the default value of extra size to same as max buffer value. I do not foresee any scenario where record extra size is more than the actual record size. So this value is going to be sufficient and possibly there would not be any need to configure jute.maxbuffer.extrasize. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services