From notifications-return-1887-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Sep 18 14:59:25 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AC14E180652 for ; Wed, 18 Sep 2019 16:59:24 +0200 (CEST) Received: (qmail 13019 invoked by uid 500); 18 Sep 2019 14:59:24 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 12991 invoked by uid 99); 18 Sep 2019 14:59:24 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Sep 2019 14:59:24 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] anmolnar commented on a change in pull request #1079: ZOOKEEPER-3231:Purge task may lost data when the recent snapshots are all invalid Message-ID: <156881876399.7994.13658743065913216352.gitbox@gitbox.apache.org> Date: Wed, 18 Sep 2019 14:59:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anmolnar commented on a change in pull request #1079: ZOOKEEPER-3231:Purge task may lost data when the recent snapshots are all invalid URL: https://github.com/apache/zookeeper/pull/1079#discussion_r325726899 ########## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/PurgeTxnTest.java ########## @@ -484,6 +494,48 @@ public void testPurgeDoesNotDeleteOverlappingLogFile() throws Exception { zks.shutdown(); } + @Test + public void testPurgeTxnLogWhenRecentSnapshotsAreAllInvalid() throws Exception { + tmpDir = ClientBase.createTmpDir(); Review comment: Please consider moving this in a `setUp()` method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services