zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format
Date Mon, 30 Sep 2019 18:01:01 GMT
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format
URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329701159
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
 ##########
 @@ -169,7 +169,7 @@ public synchronized void updateAck(long zxid) {
                 nextTime = 0;
                 nextZxid = 0;
             } else if (nextZxid == zxid) {
-                LOG.warn("ACK for " + zxid + " received before ACK for " + currentZxid +
"!!!!");
+                LOG.warn("ACK for {} received before ACK for {}!!!!", zxid, currentZxid);
 
 Review comment:
   Add "0x"s for hex? (and the Long.toHexString)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message