zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format
Date Mon, 30 Sep 2019 18:01:01 GMT
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format
URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329700162
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverMaster.java
 ##########
 @@ -293,11 +293,12 @@ public synchronized long startForwarding(LearnerHandler learnerHandler,
long las
         if (itr.hasNext()) {
             QuorumPacket packet = itr.next();
             if (packet.getZxid() > lastSeenZxid + 1) {
-                LOG.error("LearnerHandler is too far behind ({} < {}), disconnecting {}
at {}",
-                          Long.toHexString(lastSeenZxid + 1),
-                          Long.toHexString(packet.getZxid()),
-                          learnerHandler.getSid(),
-                          learnerHandler.getRemoteAddress());
+                LOG.error(
+                    "LearnerHandler is too far behind ({} < {}), disconnecting {} at {}",
 
 Review comment:
   Add "0x"'s for hex?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message