zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] hanm commented on a change in pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages
Date Thu, 26 Sep 2019 23:32:35 GMT
hanm commented on a change in pull request #1081: ZOOKEEPER-3537: Leader election - Use of
out of election messages
URL: https://github.com/apache/zookeeper/pull/1081#discussion_r328865837
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java
 ##########
 @@ -1045,6 +1057,9 @@ public Vote lookForLeader() throws InterruptedException {
                         /*
                          * Before joining an established ensemble, verify that
                          * a majority are following the same leader.
+                         *
+                         * Note that the outofelection map also stores votes from the current
leader election.
+                         * See ZOOKEEPER-1732 for more information.
 
 Review comment:
   Is `ZOOKEEPER-1732` the right JIRA? That JIRA has no direct correlation with the comment
added here, as far as I can tell.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message