zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] insumity commented on issue #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages
Date Sun, 22 Sep 2019 18:35:09 GMT
insumity commented on issue #1081: ZOOKEEPER-3537: Leader election - Use of out of election
messages
URL: https://github.com/apache/zookeeper/pull/1081#issuecomment-533906506
 
 
   @enixon As said in the [JIRA ticket](https://issues.apache.org/jira/browse/ZOOKEEPER-3537)

   > If checkLeader on outofelection fails, although it would have succeeded in `recvset`,
`checkLeader` succeeds immediately afterwards when the vote is added in `outofelection`.
   
   so, the way the code was before did not (or could) cause any issues whatsoever. 
   However, the proposed changed seems more clear and I believe it could prevent others from
wasting time to see if something's wrong in case they notice this discrepancy. The discrepancy
being adding notifications in `recvset` but checking for a leader in `outofelection`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message