zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] anmolnar commented on a change in pull request #1079: ZOOKEEPER-3231:Purge task may lost data when the recent snapshots are all invalid
Date Wed, 18 Sep 2019 14:59:23 GMT
anmolnar commented on a change in pull request #1079: ZOOKEEPER-3231:Purge task may lost data
when the recent snapshots are all invalid
URL: https://github.com/apache/zookeeper/pull/1079#discussion_r325726899
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/PurgeTxnTest.java
 ##########
 @@ -484,6 +494,48 @@ public void testPurgeDoesNotDeleteOverlappingLogFile() throws Exception
{
         zks.shutdown();
     }
 
+    @Test
+    public void testPurgeTxnLogWhenRecentSnapshotsAreAllInvalid() throws Exception {
+        tmpDir = ClientBase.createTmpDir();
 
 Review comment:
   Please consider moving this in a `setUp()` method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message