zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] maoling commented on issue #1091: ZOOKEEPER-3546: Delete empty containers with cversion == 0 after a grace period
Date Wed, 18 Sep 2019 03:27:56 GMT
maoling commented on issue #1091: ZOOKEEPER-3546: Delete empty containers with cversion ==
0 after a grace period
URL: https://github.com/apache/zookeeper/pull/1091#issuecomment-532502795
 
 
   - this change has violated the semantic of CONTAINER node designed from [ZOOKEEPER-2163](https://issues.apache.org/jira/browse/ZOOKEEPER-2163),
   making the behavior of CONTAINER node very weird.
   
   > This proposal adds a new node type, CONTAINER. A CONTAINER node **is the same as a
PERSISTENT node** with the additional property that when its last child is deleted, it is
deleted (and CONTAINER nodes recursively up the tree are deleted if empty).
   
   - Further:the exist of CONTAINER node is an important flag for the developers to implement
their recipes.how can I distinguish the Non-existent of that CONTAINER node is because of
all her children have been deleted or she has no children at all.
   - What a scene I can image is: I have a main task which has many sub-tasks, then I can
create a container node` /main-task`, then create ephemeral sequence nodes for every sub-tasks(e.g:`/main-task/sub-task1,/main-task/sub-task2`),
a sub-task deleted its node after finishing its task.the main task will observer the existent
of `/main-task` to judge whether the main task has finished successfully. If we pick up this
patch, if all the sub-threads have all failed, after some time, the main task will also observer
the in-existent of` /main-task`, mistakenly consider the state of main-task.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message