zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] hanm opened a new pull request #1092: ZOOKEEPER-3548: Redundant zxid check in SnapStream.isValidSnapshot.
Date Tue, 17 Sep 2019 03:50:44 GMT
hanm opened a new pull request #1092: ZOOKEEPER-3548: Redundant zxid check in SnapStream.isValidSnapshot.
URL: https://github.com/apache/zookeeper/pull/1092
 
 
   `Util.getZxidFromName` is called twice in `SnapStream.isValidSnapshot`, and the second
call is redundant: there is no way the check would return false when the second call of `Util.getZxidFromName`
is executed as otherwise the code would already return false in the first call of `Util.getZxidFromName`.
   
   No test as the logic is fairly obvious (and the logic is not well testable, in first place).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message