zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] symat commented on issue #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+
Date Tue, 10 Sep 2019 09:16:16 GMT
symat commented on issue #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+
URL: https://github.com/apache/zookeeper/pull/1056#issuecomment-529848711
 
 
   Thanks @lvfangmin for the comments!
   
   I moved the `digestEnabled` to `ZooKeeperServer` class, and also created a setter for it.
I saw that other configuration options are usually initialized by system properties, but then
there are setters for them, which can also be used by the test code. So I followed this pattern.
   
   In this way the `digestEnabled` option can be set from the code, while the digestVersion
is still 'hidden' with `private static final` in `DigestCalculator`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message