zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] nkalmar commented on a change in pull request #993: ZOOKEEPER-3436 Enhance Mavenized Make C client
Date Tue, 03 Sep 2019 08:35:48 GMT
nkalmar commented on a change in pull request #993: ZOOKEEPER-3436 Enhance Mavenized Make C
client
URL: https://github.com/apache/zookeeper/pull/993#discussion_r320152335
 
 

 ##########
 File path: zookeeper-client/zookeeper-client-c/pom.xml
 ##########
 @@ -97,7 +58,7 @@
           </execution>
           <execution>
             <id>configure</id>
-            <phase>test-compile</phase>
+            <phase>process-sources</phase>
 
 Review comment:
   This is where --enable-gcov is passed, the phase which this runs probably surfaced the
problem for Patrick? If someone doesn't have the library it will always fail, with ant only
if they run a c-coverege report.
   Thanks @symat for finding this!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message