zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] symat edited a comment on issue #993: ZOOKEEPER-3436 Enhance Mavenized Make C client
Date Tue, 03 Sep 2019 08:14:32 GMT
symat edited a comment on issue #993: ZOOKEEPER-3436 Enhance Mavenized Make C client
URL: https://github.com/apache/zookeeper/pull/993#issuecomment-527353396
 
 
   we found the problem with @nkalmar:
   
   the gcov library is used only when the `--enable-gcov` parameter is passed to the `configure`
call. This parameter was used in the ant file only for the target `c_coverage_report` but
not during the normal test / build targets. Currently in maven it is hardcoded to be always
passed to the `configure` script. And most probably the `gcov` library is not present on Patrick's
machine.
   
   (https://github.com/eolivelli/zookeeper/blob/44f6ba5d2530d3376e469524df0b946b77a69fcb/zookeeper-client/zookeeper-client-c/pom.xml#L74)
   
   It would be nice to introduce an optional maven parameter and not using gcov by default.
(It doesn't make much sense to measure test coverage all the time when we want to build the
client).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message