From notifications-return-1544-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sun Aug 25 02:56:22 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 97C591804BB for ; Sun, 25 Aug 2019 04:56:22 +0200 (CEST) Received: (qmail 10303 invoked by uid 500); 25 Aug 2019 02:56:21 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 10294 invoked by uid 99); 25 Aug 2019 02:56:21 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 25 Aug 2019 02:56:21 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] TisonKun commented on a change in pull request #839: ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed Message-ID: <156670178158.16010.526258507518030473.gitbox@gitbox.apache.org> Date: Sun, 25 Aug 2019 02:56:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit TisonKun commented on a change in pull request #839: ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed URL: https://github.com/apache/zookeeper/pull/839#discussion_r317380458 ########## File path: zookeeper-jute/src/main/java/org/apache/jute/compiler/JCompType.java ########## @@ -54,7 +54,7 @@ String genJavaCompareTo(String fname) { } String genJavaEquals(String fname, String peer) { - return " ret = " + fname + ".equals(" + peer + ");\n"; + return " ret = java.util.Objects.equals(" + fname + ", " + peer + ");\n"; Review comment: Unless we state that jute generated s will never contain a null field. Then we can think of `""` or `""` or sth. else. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services