From notifications-return-1534-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sat Aug 24 19:50:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id ACEBB1804BB for ; Sat, 24 Aug 2019 21:50:40 +0200 (CEST) Received: (qmail 26356 invoked by uid 500); 24 Aug 2019 19:50:40 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 26347 invoked by uid 99); 24 Aug 2019 19:50:40 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Aug 2019 19:50:40 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] TisonKun commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed Message-ID: <156667623993.3305.16655924233855495254.gitbox@gitbox.apache.org> Date: Sat, 24 Aug 2019 19:50:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit TisonKun commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-524576198 Hi @anmolnar @eolivelli @maoling I'd like to revive this thread. I have rebased this pull request to our master and now I have more understanding on this scope. For backward compatibility, I think jute is fine with field addition. Specifically, I test 1. nightly server with 3.4.14/3.5.5 client Client report ``` Exception in thread "main" org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode ``` because older client deserialized bytes but didn't understand path field. 2. 3.4.14/3.5.5 server with nightly client Client report ``` Exception in thread "main" org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode ``` because nightly client deserialized bytes but didn't find a path field since old serve never fulfilled it. 2. nightly server with nightly client worked as expected. @anmolnar theoretically we have no backward compatibility thanks to jute. Thus I don't think we need to introduce a switch but just upgrade safely. Could you please retest the case to see if your argument last? If so, I'd like to learn the detail because jute should have prevented us from that. also cc @phunt @nkalmar ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services