From notifications-return-1470-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Aug 16 04:47:43 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8C57A180645 for ; Fri, 16 Aug 2019 06:47:43 +0200 (CEST) Received: (qmail 98086 invoked by uid 500); 16 Aug 2019 04:47:43 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 98077 invoked by uid 99); 16 Aug 2019 04:47:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Aug 2019 04:47:42 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server Message-ID: <156593086271.27685.17066839884179799369.gitbox@gitbox.apache.org> Date: Fri, 16 Aug 2019 04:47:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314581891 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java ########## @@ -1268,11 +1256,7 @@ public void run() { } else if (e instanceof SocketException) { LOG.info("Socket error occurred: {}: {}", serverAddress, e.getMessage()); } else { - LOG.warn("Session 0x{} for server {}, unexpected error{}", - Long.toHexString(getSessionId()), - serverAddress, - RETRY_CONN_MSG, - e); + LOG.warn("Session 0x{} for server {}, unexpected error{}", Long.toHexString(getSessionId()), serverAddress, RETRY_CONN_MSG, e); Review comment: In fact I locally turn on `LineLength` and see that there is about 200 files break the rules, a pass to take care of it is ok for this pr. But not all of them have a reasonable break down strategy to apply on. Some of them are just because too much indent level so break line length rule. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services