From notifications-return-1469-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Aug 16 04:44:54 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4DDD2180645 for ; Fri, 16 Aug 2019 06:44:54 +0200 (CEST) Received: (qmail 93627 invoked by uid 500); 16 Aug 2019 04:44:53 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 93618 invoked by uid 99); 16 Aug 2019 04:44:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Aug 2019 04:44:53 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server Message-ID: <156593069331.26279.2929950550978669916.gitbox@gitbox.apache.org> Date: Fri, 16 Aug 2019 04:44:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314581508 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java ########## @@ -925,15 +926,11 @@ else if (serverPath.length() > chrootPath.length()) */ try { if (packet.requestHeader.getXid() != replyHdr.getXid()) { - packet.replyHeader.setErr( - KeeperException.Code.CONNECTIONLOSS.intValue()); - throw new IOException("Xid out of order. Got Xid " - + replyHdr.getXid() + " with err " + - + replyHdr.getErr() + - " expected Xid " - + packet.requestHeader.getXid() - + " for a packet with details: " - + packet ); + packet.replyHeader.setErr(KeeperException.Code.CONNECTIONLOSS.intValue()); + throw new IOException("Xid out of order. Got Xid " + replyHdr.getXid() + + " with err " + +replyHdr.getErr() Review comment: Nice catch. Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services