From notifications-return-1463-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Aug 16 04:00:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B0629180651 for ; Fri, 16 Aug 2019 06:00:05 +0200 (CEST) Received: (qmail 46116 invoked by uid 500); 16 Aug 2019 04:00:05 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 46000 invoked by uid 99); 16 Aug 2019 04:00:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Aug 2019 04:00:03 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] hanm commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server Message-ID: <156592800360.4035.11710307113674875658.gitbox@gitbox.apache.org> Date: Fri, 16 Aug 2019 04:00:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hanm commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314574017 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java ########## @@ -200,9 +195,7 @@ public static void visitSubTreeDFS(ZooKeeper zk, final String path, boolean watc } @SuppressWarnings("unchecked") - private static void visitSubTreeDFSHelper(ZooKeeper zk, final String path, - boolean watch, StringCallback cb) - throws KeeperException, InterruptedException { + private static void visitSubTreeDFSHelper(ZooKeeper zk, final String path, boolean watch, StringCallback cb) throws KeeperException, InterruptedException { Review comment: very long line again ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services