From notifications-return-1315-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Aug 12 17:31:48 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 80EB5180637 for ; Mon, 12 Aug 2019 19:31:48 +0200 (CEST) Received: (qmail 4582 invoked by uid 500); 12 Aug 2019 17:31:48 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 4570 invoked by uid 99); 12 Aug 2019 17:31:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Aug 2019 17:31:47 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] hanm commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server Message-ID: <156563110784.26702.17211643158604820602.gitbox@gitbox.apache.org> Date: Mon, 12 Aug 2019 17:31:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hanm commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server URL: https://github.com/apache/zookeeper/pull/1049#discussion_r313037852 ########## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/WatcherTest.java ########## @@ -142,18 +137,16 @@ public void processResult(int rc, String path, Object ctx) { } } } - + @Test - public void testWatcherDisconnectOnClose() - throws IOException, InterruptedException, KeeperException - { + public void testWatcherDisconnectOnClose() throws Exception { Review comment: Unnecessary exception type change? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services