From notifications-return-1265-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sun Aug 11 17:38:45 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9BE58180670 for ; Sun, 11 Aug 2019 19:38:45 +0200 (CEST) Received: (qmail 33202 invoked by uid 500); 11 Aug 2019 17:38:44 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 33112 invoked by uid 99); 11 Aug 2019 17:38:44 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Aug 2019 17:38:44 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] enixon commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server Message-ID: <156554512449.16908.16487488421093504100.gitbox@gitbox.apache.org> Date: Sun, 11 Aug 2019 17:38:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit enixon commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server URL: https://github.com/apache/zookeeper/pull/1049#discussion_r312748141 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java ########## @@ -928,12 +925,12 @@ else if (serverPath.length() > chrootPath.length()) packet.replyHeader.setErr( KeeperException.Code.CONNECTIONLOSS.intValue()); throw new IOException("Xid out of order. Got Xid " - + replyHdr.getXid() + " with err " + - + replyHdr.getErr() + - " expected Xid " + + replyHdr.getXid() + " with err " + + +replyHdr.getErr() Review comment: This `+ +` can be cleaned up. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services