From notifications-return-1210-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Aug 8 15:39:11 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B7222180642 for ; Thu, 8 Aug 2019 17:39:10 +0200 (CEST) Received: (qmail 25388 invoked by uid 500); 8 Aug 2019 15:39:10 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 25379 invoked by uid 99); 8 Aug 2019 15:39:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Aug 2019 15:39:10 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] lvfangmin commented on a change in pull request #1025: [ZOOKEEPER-3471] Fix potential lock unavailable due to dangling ephemeral nodes left during local session upgrading Message-ID: <156527875007.29426.15199555820975355538.gitbox@gitbox.apache.org> Date: Thu, 08 Aug 2019 15:39:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lvfangmin commented on a change in pull request #1025: [ZOOKEEPER-3471] Fix potential lock unavailable due to dangling ephemeral nodes left during local session upgrading URL: https://github.com/apache/zookeeper/pull/1025#discussion_r312105620 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ########## @@ -992,6 +990,7 @@ public void submitRequestNow(Request si) { touch(si.cnxn); boolean validpacket = Request.isValid(si.type); if (validpacket) { + setLocalSessionFlag(si); Review comment: I'm not quite sure I understand your question here, all the requests will go through RequestThrottler, and then being put into RequestProcessor now. So no request will be put into RequestProcessor directly, right? Let me know if I didn't get your question. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services