From notifications-return-1057-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Aug 1 05:55:50 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 66973180654 for ; Thu, 1 Aug 2019 07:55:50 +0200 (CEST) Received: (qmail 25241 invoked by uid 500); 1 Aug 2019 05:55:49 -0000 Mailing-List: contact notifications-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list notifications@zookeeper.apache.org Received: (qmail 25225 invoked by uid 99); 1 Aug 2019 05:55:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Aug 2019 05:55:49 +0000 From: GitBox To: notifications@zookeeper.apache.org Subject: [GitHub] [zookeeper] lvfangmin commented on a change in pull request #1007: ZOOKEEPER-3448: Introduce MessageTracker to assist debug leader and leaner connectivity issues. Message-ID: <156463894976.13053.5690357920125938854.gitbox@gitbox.apache.org> Date: Thu, 01 Aug 2019 05:55:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lvfangmin commented on a change in pull request #1007: ZOOKEEPER-3448: Introduce MessageTracker to assist debug leader and leaner connectivity issues. URL: https://github.com/apache/zookeeper/pull/1007#discussion_r309532603 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java ########## @@ -271,6 +280,8 @@ protected void setBufferedOutput(BufferedOutputStream bufferedOutput) { } throw new SaslException("Authentication failure: " + e.getMessage()); } + + this.messageTracker = new MessageTracker(BUFFERED_MESSAGE_SIZE); Review comment: @hanm I understand the logging part is low cost, but add/remove all the packets in the synchronized FIFO CircularBuffer is not trivial on high traffic environment, that's why I concerned about the performance. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services