zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] lvfangmin commented on issue #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+
Date Thu, 29 Aug 2019 19:16:05 GMT
lvfangmin commented on issue #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+
URL: https://github.com/apache/zookeeper/pull/1056#issuecomment-526323567
 
 
   This version with mockito.spy looks good to me, as long as we don't use things like setVersion.
   
   The only downside of this is we'll need to pass the DigestCalculator around after changing
it to non-static, probably I'll move the digestEnabled to some which could be shared across
different classes.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message