zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] symat commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+
Date Thu, 29 Aug 2019 17:55:10 GMT
symat commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to
work with JDK12+
URL: https://github.com/apache/zookeeper/pull/1056#discussion_r319197471
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/util/DigestCalculator.java
 ##########
 @@ -35,18 +35,21 @@
 
     // The hardcoded digest version, should bump up this version whenever
     // we changed the digest method or fields.
-    //
-    // Defined it as Integer to make it able to be changed in test via reflection
-    public static final Integer DIGEST_VERSION = 2;
+    private static final int DIGEST_VERSION = 2;
 
     public static final String ZOOKEEPER_DIGEST_ENABLED = "zookeeper.digest.enabled";
-    private static boolean digestEnabled;
 
     static {
-        digestEnabled = Boolean.parseBoolean(System.getProperty(ZOOKEEPER_DIGEST_ENABLED,
"true"));
-        LOG.info("{} = {}", ZOOKEEPER_DIGEST_ENABLED, digestEnabled);
+        LOG.info("{} = {}", ZOOKEEPER_DIGEST_ENABLED, System.getProperty(ZOOKEEPER_DIGEST_ENABLED,
"true"));
     }
 
+    private boolean digestEnabled;
+
+    public DigestCalculator() {
 
 Review comment:
   This is a good idea. I tried it, but in `SnapshotDigestTest.testDifferentDigestVersion`
we create a Mockito Spy on the class and apparently you can not create Mockito Spy on a final
class.
   
   So instead of this I take @anmolnar 's original idea and moved this class to the `server`
package and made it packet private, so at least it can not be overwritten from non-ZK code.
Let's hope it will work also for @lvfangmin. If not, then we can move back...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message