zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] symat commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+
Date Thu, 29 Aug 2019 17:55:10 GMT
symat commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to
work with JDK12+
URL: https://github.com/apache/zookeeper/pull/1056#discussion_r319197286
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/DataTreeTest.java
 ##########
 @@ -219,7 +219,7 @@ public void testPzxidUpdatedWhenDeletingNonExistNode() throws Exception
{
     @Test
     public void testDigestUpdatedWhenReplayCreateTxnForExistNode() {
         try {
-            DigestCalculator.setDigestEnabled(true);
+            System.setProperty(DigestCalculator.ZOOKEEPER_DIGEST_ENABLED, "true");
 
 Review comment:
   Nice catch, thanks! I modified the test to create a new DataTree after setting the system
property.
   (I also made the test cleaner by creating the DataTree now only in the test cases and removed
the field from the `setUp` method - previously half the tests used the field, half of them
not)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message