zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton
Date Thu, 29 Aug 2019 12:20:08 GMT
eolivelli commented on a change in pull request #1064: ZOOKEEPER-3523: Replace dummy watcher
with a unified singleton
URL: https://github.com/apache/zookeeper/pull/1064#discussion_r319035410
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/Watcher.java
 ##########
 @@ -31,6 +31,8 @@
 @InterfaceAudience.Public
 public interface Watcher {
 
+    Watcher DUMMY_WATCHER = event -> { };
 
 Review comment:
   Please do not add this constant to this public API.
   If you want to do this change for tests let's create a class inside the test packages

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message