zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+
Date Thu, 29 Aug 2019 09:30:28 GMT
eolivelli commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest
to work with JDK12+
URL: https://github.com/apache/zookeeper/pull/1056#discussion_r318972678
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/util/DigestCalculator.java
 ##########
 @@ -35,18 +35,21 @@
 
     // The hardcoded digest version, should bump up this version whenever
     // we changed the digest method or fields.
-    //
-    // Defined it as Integer to make it able to be changed in test via reflection
-    public static final Integer DIGEST_VERSION = 2;
+    private static final int DIGEST_VERSION = 2;
 
     public static final String ZOOKEEPER_DIGEST_ENABLED = "zookeeper.digest.enabled";
-    private static boolean digestEnabled;
 
     static {
-        digestEnabled = Boolean.parseBoolean(System.getProperty(ZOOKEEPER_DIGEST_ENABLED,
"true"));
-        LOG.info("{} = {}", ZOOKEEPER_DIGEST_ENABLED, digestEnabled);
+        LOG.info("{} = {}", ZOOKEEPER_DIGEST_ENABLED, System.getProperty(ZOOKEEPER_DIGEST_ENABLED,
"true"));
     }
 
+    private boolean digestEnabled;
+
+    public DigestCalculator() {
 
 Review comment:
   Let's make the class 'final' it will slightly help the JVM for optimizations.
   We had 'static' methods that were not overridable.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message