zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] shralex commented on a change in pull request #1063: ZOOKEEPER 3522: Consistency guarantees discussion.
Date Tue, 27 Aug 2019 20:15:36 GMT
shralex commented on a change in pull request #1063: ZOOKEEPER 3522: Consistency guarantees
discussion.
URL: https://github.com/apache/zookeeper/pull/1063#discussion_r318268525
 
 

 ##########
 File path: zookeeper-docs/src/main/resources/markdown/zookeeperInternals.md
 ##########
 @@ -52,18 +55,17 @@ At the heart of ZooKeeper is an atomic messaging system that keeps all
of the se
 The specific guarantees provided by the messaging system used by ZooKeeper are the following:
 
 * *_Reliable delivery_* :
-    If a message, m, is delivered
-    by one server, it will be eventually delivered by all servers.
+    If a message `m`, is delivered
+    by one server, message `m` will be eventually delivered by all servers.
 
 Review comment:
   Not this PR's fault, but this seems inaccurate - it mixes a bunch of properties usually
used to define reliable broadcast. https://en.wikipedia.org/wiki/Terminating_Reliable_Broadcast
   
   Also, pretty much all the definitions here require things from "server" whereas this should
be "correct server", i.e., one that doesn't fail during the execution. Maybe one of the Zab
authors can fix it in a separate PR.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message