zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] TisonKun commented on a change in pull request #839: ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed
Date Sun, 25 Aug 2019 02:59:34 GMT
TisonKun commented on a change in pull request #839: ZOOKEEPER-3290: Throw detailed KeeperException
when multi-op failed
URL: https://github.com/apache/zookeeper/pull/839#discussion_r317380515
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/MultiOperationTest.java
 ##########
 @@ -621,7 +654,7 @@ public void testOpResultEquals() {
 
         opEquals(new DeleteResult(), new DeleteResult(), null);
 
-        opEquals(new ErrorResult(1), new ErrorResult(1), new ErrorResult(2));
+        opEquals(new ErrorResult(1, "/foo"), new ErrorResult(1, "/foo"), new ErrorResult(1,
"/bar"));
 
 Review comment:
   I intend to add a new verification, but it happens we already have 
   
   ```java
   opEquals(new ErrorResult(1), new ErrorResult(1), new ErrorResult(2));
   ``
   
   lines above, so I add a new one and delete the duplicate one. It is now a modification.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message