zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] TisonKun commented on a change in pull request #839: ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed
Date Sun, 25 Aug 2019 02:56:21 GMT
TisonKun commented on a change in pull request #839: ZOOKEEPER-3290: Throw detailed KeeperException
when multi-op failed
URL: https://github.com/apache/zookeeper/pull/839#discussion_r317380458
 
 

 ##########
 File path: zookeeper-jute/src/main/java/org/apache/jute/compiler/JCompType.java
 ##########
 @@ -54,7 +54,7 @@ String genJavaCompareTo(String fname) {
     }
 
     String genJavaEquals(String fname, String peer) {
-        return "    ret = " + fname + ".equals(" + peer + ");\n";
+        return "    ret = java.util.Objects.equals(" + fname + ", " + peer + ");\n";
 
 Review comment:
   Unless we state that jute generated s will never contain a null field. Then we can think
of `"<null>"` or `"<unknown>"` or sth. else.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message