zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #839: ZOOKEEPER-3290: Throw detailed KeeperException when multi-op failed
Date Sat, 24 Aug 2019 22:12:40 GMT
eolivelli commented on a change in pull request #839: ZOOKEEPER-3290: Throw detailed KeeperException
when multi-op failed
URL: https://github.com/apache/zookeeper/pull/839#discussion_r317375472
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/CreateMode.java
 ##########
 @@ -135,7 +135,7 @@ public static CreateMode fromFlag(int flag) throws KeeperException {
         default:
             String errMsg = "Received an invalid flag value: " + flag + " to convert to a
CreateMode";
             LOG.error(errMsg);
-            throw new KeeperException.BadArgumentsException(errMsg);
+            throw new KeeperException.BadArgumentsException();
 
 Review comment:
   good catchm this is not a "path".
   I wonder if we can somehow preserve the "message"
   I see that KeeperException has a bad way of dealing with the "exception message".
   Maybe we should clean up it.
   Is is so bad to keep errMsg here ? and clean up this stuff in a separate commit ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message