zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] TisonKun commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed
Date Sat, 24 Aug 2019 19:50:39 GMT
TisonKun commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction
failed
URL: https://github.com/apache/zookeeper/pull/839#issuecomment-524576198
 
 
   Hi @anmolnar @eolivelli @maoling I'd like to revive this thread.
   
   I have rebased this pull request to our master and now I have more understanding on this
scope.
   
   For backward compatibility, I think jute is fine with field addition. Specifically, I test
   
   1. nightly server with 3.4.14/3.5.5 client
   
   Client report 
   
   ```
   Exception in thread "main" org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode
= NoNode
   ```
   
   because older client deserialized bytes but didn't understand path field.
   
   2. 3.4.14/3.5.5 server with nightly client
   
   Client report 
   
   ```
   Exception in thread "main" org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode
= NoNode
   ```
   
   because nightly client deserialized bytes but didn't find a path field since old serve
never fulfilled it.
   
   2. nightly server with nightly client
   
   worked as expected.
   
   @anmolnar theoretically we have no backward compatibility thanks to jute. Thus I don't
think we need to introduce a switch but just upgrade safely. Could you please retest the case
to see if your argument last? If so, I'd like to learn the detail because jute should have
prevented us from that.
   
   also cc @phunt @nkalmar 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message