zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] anmolnar commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+
Date Wed, 21 Aug 2019 20:03:59 GMT
anmolnar commented on a change in pull request #1056: ZOOKEEPER-3495: fix SnapshotDigestTest
to work with JDK12+
URL: https://github.com/apache/zookeeper/pull/1056#discussion_r316376134
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NodeHashMapImpl.java
 ##########
 @@ -33,6 +33,7 @@
     private final ConcurrentHashMap<String, DataNode> nodes = new ConcurrentHashMap<String,
DataNode>();
 
     private AdHash hash = new AdHash();
+    private final DigestCalculator digestCalculator = new DigestCalculator();
 
 Review comment:
   Rather than instantiating new object here, request for it in the constructor. You should
get the same object as `DataTree` is using.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message