zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] lvfangmin commented on issue #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+
Date Tue, 20 Aug 2019 18:53:24 GMT
lvfangmin commented on issue #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+
URL: https://github.com/apache/zookeeper/pull/1056#issuecomment-523148710
 
 
   The DIGEST_VERSION is made to be static final to make sure it won't be changed in code
with things like setVersion.
   
   It seems to be safer and cleaner to me with the current code implementation, for the test
if we want to avoid reflection we add a pre-defined snapshot file with different digest version
(like -1), and test the difference version case.
   
   Also DigestCalculator is not only used in DataTree, it will also being used in PrepRequestProcessor
when adding real time digest on txn, so this class is more about a util which could be replaced
with different digest method. I'm preparing the PR in the last few days, will send the PR
probably today.
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message