zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] roodkcab commented on issue #970: ZOOKEEPER-2122: SSL/TLS support in ZK C Client
Date Tue, 20 Aug 2019 16:47:29 GMT
roodkcab commented on issue #970: ZOOKEEPER-2122: SSL/TLS support in ZK C Client
URL: https://github.com/apache/zookeeper/pull/970#issuecomment-523099343
 
 
   > 
   > The change in zk_adaptor.h, at the top of the _zhandle struct, the fd variable get
redefined (it's both zsock_t * and then SOCKET).
   > 
   > It looks like zsock_t is meant to replace the plain numeric file descriptors, so shouldn't
the change here remove the #ifdef entirely and use just use zsock_t?
   
   exactly, the #ifdef should be removed, the plain socket descriptor is now wrapped in zsock_t
with ssl context when openssl is turned on. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message