zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] symat commented on issue #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+
Date Fri, 16 Aug 2019 10:10:50 GMT
symat commented on issue #1056: ZOOKEEPER-3495: fix SnapshotDigestTest to work with JDK12+
URL: https://github.com/apache/zookeeper/pull/1056#issuecomment-521959851
 
 
   @eolivelli 
   > I suggested to add a setter method, so mo more need for reflection
   
   if we want to avoid both reflection and mocking, then we actually need two setter methods,
one for the setEnable and one for the setVersion. Both of the fields can be made volatile
in this case I think.
   
   we can add `@VisibleForTesting` on the setter methods - do we use that in Zookeeper? I
found it, but always it is commented out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message