zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
Date Fri, 16 Aug 2019 05:55:49 GMT
eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration
on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314591200
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
 ##########
 @@ -433,22 +417,22 @@ public WatcherSetEventPair(Set<Watcher> watchers, WatchedEvent
event) {
      */
     private static String makeThreadName(String suffix) {
         String name = Thread.currentThread().getName().
-            replaceAll("-EventThread", "");
+                                                              replaceAll("-EventThread",
"");
 
 Review comment:
   @hanm just to be clear, checkstyle does not format the code, it is only a set of rules.
   @TisonKun is using a bunch of tools like scripts/IDEs to reformat the code in a way that
makes checkstyle happy.
   Actually we decided to disable the only rule about line length, so overflowing lines could
be left as they were originally.
   I guess that @TisonKun's tools anyway want to restrict the max line length

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message