zookeeper-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] TisonKun edited a comment on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server
Date Thu, 15 Aug 2019 17:41:30 GMT
TisonKun edited a comment on issue #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on
zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-521730229
 
 
   Also it is a pain to handle multiple log formats which also make formatting harder. I would
propose a best effort(i.e. no rule to enforce this) on the fly reformatting on log style(string
concat style) that when the line is too long and variable interception matters, use the pattern
below.
   
   ```
   log.info("...{} ...{}", arg1, arg2)
   ```
   
   instead of string concat. This also works on `String.format`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message